IRCv3 batch support - #1938
IRCv3 batch support#1938vanosg wants to merge 16 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c834bafb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Incorporated @thommey's feedback on providing the option to avoid triggering previous binds in commands like chathistory by adding a 'suppress' member to the batch struct and checking it on batch sessions. If suppress is set to 1, check_tcl_raw is not called, which is where the other binds are called from (pub, msg, join, etc). In short similar to rawt- if check_tcl_batch returns 1, set suppressed to 1. Every subsequent line is run checks message tags for a batch reference and pulls the record from the batch table. If suppress is set to 1, don't trigger check_tcl_raw. Does this inject processing issues I'm not considering? Is it ok to check this every line like this? It feels heavy |
| putlog(LOG_DEBUG, "*", "BATCH: opened %s (type %s)%s%s", b->reftag, | ||
| b->type, b->parent ? ", nested in " : "", | ||
| b->parent ? b->parent->reftag : ""); | ||
| /* Suppress session if parent session is suppressed */ |
|
Patch by: Geo
One-line summary:
Add IRCv3 batch capability support, and use netsplit batches for netsplit detection
Additional description (if needed):
Test cases demonstrating functionality (if applicable):