Skip to content

feat: allow to do git commits with a custom user - #58

Open
gabor-boros wants to merge 2 commits into
eduNEXT:mainfrom
open-craft:gabor/allow-custom-git-user
Open

feat: allow to do git commits with a custom user#58
gabor-boros wants to merge 2 commits into
eduNEXT:mainfrom
open-craft:gabor/allow-custom-git-user

Conversation

@gabor-boros

Copy link
Copy Markdown
Contributor

Description

This PR allows Picasso's users to set a custom user and email for the git commit step. The default values of the new inputs are the same as it was assigned earlier, therefore not setting the values result in the same GitHub user and email address as it was before this PR.

Signed-off-by: Gabor Boros <gabor@opencraft.com>
Signed-off-by: Gabor Boros <gabor@opencraft.com>
@gabor-boros
gabor-boros requested a review from a team as a code owner August 6, 2026 09:10
@magajh
magajh self-requested a review August 6, 2026 14:03
@gabor-boros

Copy link
Copy Markdown
Contributor Author

Hey @magajh may I ask for a review on this? 😊

@MaferMazu MaferMazu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@magajh, do you have something to add?

@magajh magajh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, although I haven't had a chance to test it yet. @MaferMazu, did you get a chance to test it?

@magajh

magajh commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Hey @gabor-boros, I just pushed the fix for the RTD check. Could you please rebase your branch onto main?

@MaferMazu
MaferMazu self-requested a review August 20, 2026 20:09
@MaferMazu

Copy link
Copy Markdown
Contributor

LGTM as well, although I haven't had a chance to test it yet. @MaferMazu, did you get a chance to test it?

@magajh, I haven't tested execution directly since these inputs are optional and don't break existing behavior.

However, @gabor-boros, I ran a quick check through Gemini, and it flagged a potential shell injection risk with direct ${{ inputs.* }} interpolation.

Recommendation:

        env:
          GIT_COMMIT_USER_NAME: ${{ inputs.GIT_COMMIT_USER_NAME }}
          GIT_COMMIT_USER_EMAIL: ${{ inputs.GIT_COMMIT_USER_EMAIL }}
        run: |
          git config user.name "$GIT_COMMIT_USER_NAME"
          git config user.email "$GIT_COMMIT_USER_EMAIL"

Extra ref: https://docs.github.com/en/actions/reference/security/secure-use#use-an-intermediate-environment-variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants