feat: allow to do git commits with a custom user - #58
Open
gabor-boros wants to merge 2 commits into
Open
Conversation
Signed-off-by: Gabor Boros <gabor@opencraft.com>
Signed-off-by: Gabor Boros <gabor@opencraft.com>
magajh
self-requested a review
August 6, 2026 14:03
Contributor
Author
|
Hey @magajh may I ask for a review on this? 😊 |
magajh
reviewed
Aug 20, 2026
magajh
left a comment
Contributor
There was a problem hiding this comment.
LGTM as well, although I haven't had a chance to test it yet. @MaferMazu, did you get a chance to test it?
Contributor
|
Hey @gabor-boros, I just pushed the fix for the RTD check. Could you please rebase your branch onto main? |
MaferMazu
self-requested a review
August 20, 2026 20:09
Contributor
@magajh, I haven't tested execution directly since these inputs are optional and don't break existing behavior. However, @gabor-boros, I ran a quick check through Gemini, and it flagged a potential shell injection risk with direct Recommendation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Picasso's users to set a custom user and email for the git commit step. The default values of the new inputs are the same as it was assigned earlier, therefore not setting the values result in the same GitHub user and email address as it was before this PR.