Fail acquisition with the hook failure and release the lease when aft…#1684
Open
andrewkav wants to merge 1 commit into
Open
Fail acquisition with the hook failure and release the lease when aft…#1684andrewkav wants to merge 1 commit into
andrewkav wants to merge 1 commit into
Conversation
…erAcquire fails When the afterAcquire hook failed during SqlConnectionPool#acquire, the acquisition was failed with the enclosing (null) failure instead of the hook failure, so callers observed a null cause. The lease was also neither recycled nor closed, leaking the pool slot: with enough hook failures the pool starved with no way to recover. Recycle the lease and fail the acquisition with the actual hook failure. Signed-off-by: andrei <andrei@n2.games>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the afterAcquire hook failed during SqlConnectionPool#acquire, the acquisition was failed with the enclosing (null) failure instead of the hook failure, so callers observed a null cause. The lease was also neither recycled nor closed, leaking the pool slot: with enough hook failures the pool starved with no way to recover.
Recycle the lease and fail the acquisition with the actual hook failure.
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines