{correlation} changes by Tom#329
Draft
strengejacke wants to merge 33 commits into
Draft
Conversation
adding exception in bayesian correlation for when the variables are identical adding ci and p-value for all correlation as the conventional form of calculating them instead of missing
fixing the library call, following the prev fix of the test_check call
changing it to match its equivalences i other types of correlations, and adding a comment that explains the reason for the original way
discluding grouped_df
bwiernik
reviewed
Oct 16, 2024
| Package: correlation2 | ||
| Title: Methods for Correlation Analysis | ||
| Version: 0.8.4.2 | ||
| Version: 0.1.0 |
Contributor
There was a problem hiding this comment.
Let's keep the package name and versioning continuous
Member
Author
|
@mattansb How beneficial are these changes, should we / you put some work into merging those into correlation? |
Member
|
I think its worth it, but it would still be a lot of work. It could mostly be done with some agent, but whoever is working on this would need to make sure the spec Brenton and I talked about is followed. Let's talk about this offline. |
Member
|
what about creating a new repo correlation_dev, starting with a list of features of correlation to reproduce, and re-implement them one by one, and once we think it's a complete replacement and extension with do a drop-in replace here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge work from Tom into main.