Repository navigation
feat(httpapi): honor root filter on /search and MCP search - #57
Merged
Merged
Conversation
The OpenAPI spec and CLI advertised --root facts|info, but the REST handler never read the param and the MCP tool had no root argument, so confirmed- facts-only asks were impossible against the live brain. - API.Search gains asOf, root; handleSearch reads ?root= - ExecSearcher passes --root to the brain-search CLI - brain.HTTP.Search threads root into searchHits/rank.Deduce/toJSONOut - MCP search tool accepts root (via shared Op params) - spec: search Op documents root (facts or info, default all roots) - tests: REST + MCP root passthrough
The OCR job's apt-get step hung under runner lock contention. Instead: - build the test binary on the runner (go test -c) and execute it inside jitesoft/tesseract-ocr (no apt, no poppler needed for the PNG fixture) - ocr.go: OCR_LANG env override (default eng+deu) so the container image only needs eng (jitesoft ships eng/equ/osd) - job gated to GitHub (Gitea runner has no docker)
eSlider
added a commit
that referenced
this pull request
Aug 24, 2026
eSlider
added a commit
that referenced
this pull request
Aug 24, 2026
feat(httpapi): honor root filter on /search and MCP search
eSlider
added a commit
that referenced
this pull request
Sep 15, 2026
eSlider
added a commit
that referenced
this pull request
Sep 15, 2026
feat(httpapi): honor root filter on /search and MCP search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the gap where facts-only asks were impossible against the live brain: the OpenAPI spec documented
rootbut the handler never read it, and MCP had no root argument.API.Searchgainsroot;handleSearchreads?root=ExecSearcherpasses--rootto the brain-search CLIbrain.HTTP.Searchthreads root intosearchHits/rank.Deduce/toJSONOutsearchtool acceptsroot