Fix UserParameters#without being a no-op#4
Merged
Conversation
#without compared symbol keys (its only caller, CreateCasaAdminService#build, always passes symbols) against ActionController::Parameters#reject!'s string keys, so the block condition was always false and nothing was ever removed. It also didn't return self, breaking the builder chain. This let :active and :type survive into CasaAdmin.new via CreateCasaAdminService#build, letting any authenticated user set active=false on a new admin, or trigger an unrescued ActiveRecord::SubclassNotFound (500) by passing type=<sibling class>. Fixes rubyforgood#7067 Also replaces the pending spec stub in spec/values/user_parameters_spec.rb with real coverage of without, without_type, without_active, with_organization, and with_password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the fix opened upstream at rubyforgood#7070. See that PR for full context.