Skip to content

fix(windows-rocm): preserve installed families during repair - #4

Draft
Pates2004 wants to merge 7 commits into
dutch2005:feat/windows-rocm-rdna2from
Pates2004:fix/rdna2-selection-safety-20261030
Draft

Pates2004 wants to merge 7 commits into
dutch2005:feat/windows-rocm-rdna2from
Pates2004:fix/rdna2-selection-safety-20261030

Conversation

@Pates2004

@Pates2004 Pates2004 commented Oct 30, 2026 •

Copy link
Copy Markdown

Summary

Follow-up to upstream PR #3712, targeting its feature branch. Unavailable or partial GPU discovery could select the 7.2.1 overlay and replace an existing ROCm 10 installation during package repair.

Changes

  • Require complete Windows inventory before repair, preserving advisory reporting behavior.
  • Reject automatic changes between installed ROCm release families and conflicting active Torch/shared-SDK metadata before downloads or package mutation. Healthy reuse and fresh/same-family setup remain available, including a supported discrete GPU alongside an advisory iGPU.
  • Resolve test modules canonically at test time and document the repair boundary. Package pins, native verification, DLL selection and BF16 safeguards are unchanged.

Type

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • 🧪 Tests
  • 🔧 CI / Build
  • 🚀 Release prep

Testing

  • Windows: 176 passed, 1 skipped across seven focused modules, offline with initially empty HF/Torch caches. The skip is an existing Linux sysfs case unavailable on Windows.
  • Changelog fragment policy: 10 passed. The existing changelog.d/3712.added.md entry includes the repair safeguard and retains Dutch credit, so its reference stays correct when absorbed into upstream feat(windows-rocm): add verified RDNA 2 Torch and HIP CTranslate2 speech debpalash/VoiceStudio#3712.
  • Fail-before controls cover incomplete inventory, well-formed unmapped PCI IDs and conflicting active package families; repaired cases assert zero download/install calls. A separate inert control demonstrates canonical module resolution despite a stale parent-package alias.
  • No ROCm 10 installation, real GPU/model inference, independent wheel-hash verification or full CI/smoke-matrix validation was performed. This does not certify a hardware/runtime combination.

Checklist

  • I've tested this locally
  • Every non-exempt human commit author has signed the CLA
  • I've updated relevant documentation
  • User-visible change: I updated the existing upstream changelog.d/3712.added.md fragment
  • No local machine paths, logs, or personal env details in this PR
  • Maintained version files are unchanged; no version bump
  • The regression fixture still loads green on the macOS/Windows/Linux smoke-matrix CI job

Release cadence

This draft targets feat/windows-rocm-rdna2, not main. Upstream integration, hardware qualification and release/publication remain separate from this focused fix.

@github-actions

Copy link
Copy Markdown

Thank you for contributing to VoiceStudio. Before this pull request can merge, everyone who contributed to it must sign the Contributor License Agreement 1.0 once. You keep your copyright; the agreement lets Yupcha Softwares Private Limited, the company that maintains VoiceStudio, ship your work in both the AGPL-3.0 app and commercial builds.

Still to sign: @Pates2004

To sign, post this as a new comment on its own line:

I have read the VoiceStudio CLA 1.0 and I hereby sign it.

Comment recheck to run the check again.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

CLA deadline: 2026-11-15 UTC (12 days remaining). Please sign using the instructions in the CLA check above. After 14 days, maintainers may independently fix the underlying issue without using your contribution. You can still sign after the deadline; this timer does not close your pull request.

@dutch2005
dutch2005 force-pushed the feat/windows-rocm-rdna2 branch 2 times, most recently from efa16bb to da9f88c Compare November 2, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants