Skip to content

Removed all uses of I as a variable to fix conflict with complex.h #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeffreyBroll wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Removed all uses of I as a variable to fix conflict with complex.h #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1917fea
Removed all uses of I as a variable to fix conflict with complex.h
Dec 23, 2025
4013cf7
Fixing debug line consistency
Dec 23, 2025
5c87bb8
Fixing debug line and comment consistency
Dec 23, 2025
d861702
Bringing loop indices into at least the late 1900s
Dec 23, 2025
3791f62
Unclear about mixed use of I and i, so not colliding them yet
Dec 23, 2025
8e5b2eb
Continued I poking in Tools, Examples, and some HDF5-related things t…
Jan 13, 2026
cb04e71
Continued I poking in Tools, Examples, and some HDF5-related things t…
Jan 13, 2026
8f9586a
Merge branch 'drsteve:master' into stab_the_Is_out
JeffreyBroll Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Examples/LstarDipoleTest/ComputeLstarVersusPA.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ fpout = fopen(Filename, "w");

LstarInfo2->mInfo->Bm = LstarInfo3->mInfo->Bm;
if (LstarInfo3->VerbosityLevel >= 2 ) {
printf("\n\n\t%sComputing L* for: UTC = %g PA = %d (%g)%s\n", PreStr, UTC, i, MagEphemInfo->Alpha[i], PostStr );
printf(" \t%s I = %g PA = %d (%g)%s\n", PreStr, MagEphemInfo->I[i], i, MagEphemInfo->Alpha[i], PostStr );
printf("\n\n\t%sComputing L* for: UTC = %g PA = %d (%g)%s\n", PreStr, UTC, i, MagEphemInfo->Alpha[i], PostStr );
printf(" \t%s I_data = %g PA = %d (%g)%s\n", PreStr, MagEphemInfo->I_data[i], i, MagEphemInfo->Alpha[i], PostStr );
}
LS_Flag = Lstar( &v3, LstarInfo2);
if (LstarInfo3->VerbosityLevel >= 2 ) {
Expand All @@ -152,7 +152,7 @@ fpout = fopen(Filename, "w");
*/
MagEphemInfo->nShellPoints[i] = LstarInfo2->nPnts;
for (nn=0; nn<LstarInfo2->nPnts; nn++ ){
MagEphemInfo->ShellI[i][nn] = LstarInfo2->I[nn];
MagEphemInfo->ShellI[i][nn] = LstarInfo2->I_data[nn];
MagEphemInfo->ShellEllipsoidFootprint_Pn[i][nn] = LstarInfo2->Ellipsoid_Footprint_Pn[nn];
MagEphemInfo->ShellEllipsoidFootprint_Ps[i][nn] = LstarInfo2->Ellipsoid_Footprint_Ps[nn];
MagEphemInfo->ShellMirror_Pn[i][nn] = LstarInfo2->Mirror_Pn[nn];
Expand Down
6 changes: 3 additions & 3 deletions Examples/LstarDipoleTest_omp/ComputeLstarVersusPA.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ fpout = fopen(Filename, "w");

LstarInfo2->mInfo->Bm = LstarInfo3->mInfo->Bm;
if (LstarInfo3->VerbosityLevel >= 2 ) {
printf("\n\n\t%sComputing L* for: UTC = %g PA = %d (%g)%s\n", PreStr, UTC, i, MagEphemInfo->Alpha[i], PostStr );
printf(" \t%s I = %g PA = %d (%g)%s\n", PreStr, MagEphemInfo->I[i], i, MagEphemInfo->Alpha[i], PostStr );
printf("\n\n\t%sComputing L* for: UTC = %g PA = %d (%g)%s\n", PreStr, UTC, i, MagEphemInfo->Alpha[i], PostStr );
printf(" \t%s I_data = %g PA = %d (%g)%s\n", PreStr, MagEphemInfo->I_data[i], i, MagEphemInfo->Alpha[i], PostStr );
}
LS_Flag = Lstar( &v3, LstarInfo2);
if (LstarInfo3->VerbosityLevel >= 2 ) {
Expand All @@ -152,7 +152,7 @@ fpout = fopen(Filename, "w");
*/
MagEphemInfo->nShellPoints[i] = LstarInfo2->nPnts;
for (nn=0; nn<LstarInfo2->nPnts; nn++ ){
MagEphemInfo->ShellI[i][nn] = LstarInfo2->I[nn];
MagEphemInfo->ShellI[i][nn] = LstarInfo2->I_data[nn];
MagEphemInfo->ShellFootprint_Pn[i][nn] = LstarInfo2->Footprint_Pn[nn];
MagEphemInfo->ShellFootprint_Ps[i][nn] = LstarInfo2->Footprint_Ps[nn];
MagEphemInfo->ShellMirror_Pn[i][nn] = LstarInfo2->Mirror_Pn[nn];
Expand Down
6 changes: 3 additions & 3 deletions Examples/LstarVersusPA_omp/ComputeLstarVersusPA.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ void ComputeLstarVersusPA( long int Date, double UTC, Lgm_Vector *u, int nAlpha,

LstarInfo2->mInfo->Bm = LstarInfo3->mInfo->Bm;
if (LstarInfo3->VerbosityLevel >= 2 ) {
printf("\n\n\t%sComputing L* for: UTC = %g PA = %d (%g)%s\n", PreStr, UTC, i, MagEphemInfo->Alpha[i], PostStr );
printf(" \t%s I = %g PA = %d (%g)%s\n", PreStr, MagEphemInfo->I[i], i, MagEphemInfo->Alpha[i], PostStr );
printf("\n\n\t%sComputing L* for: UTC = %g PA = %d (%g)%s\n", PreStr, UTC, i, MagEphemInfo->Alpha[i], PostStr );
printf(" \t%s I_data = %g PA = %d (%g)%s\n", PreStr, MagEphemInfo->I_data[i], i, MagEphemInfo->Alpha[i], PostStr );
}
LS_Flag = Lstar( &v3, LstarInfo2);
if (LstarInfo3->VerbosityLevel >= 2 ) {
Expand All @@ -147,7 +147,7 @@ void ComputeLstarVersusPA( long int Date, double UTC, Lgm_Vector *u, int nAlpha,
*/
MagEphemInfo->nShellPoints[i] = LstarInfo2->nPnts;
for (nn=0; nn<LstarInfo2->nPnts; nn++ ){
MagEphemInfo->ShellI[i][nn] = LstarInfo2->I[nn];
MagEphemInfo->ShellI[i][nn] = LstarInfo2->I_data[nn];
MagEphemInfo->ShellEllipsoidFootprint_Pn[i][nn] = LstarInfo2->Ellipsoid_Footprint_Pn[nn];
MagEphemInfo->ShellEllipsoidFootprint_Ps[i][nn] = LstarInfo2->Ellipsoid_Footprint_Ps[nn];
MagEphemInfo->ShellMirror_Pn[i][nn] = LstarInfo2->Mirror_Pn[nn];
Expand Down
10 changes: 5 additions & 5 deletions Examples/MagEphem/MagEphemFromFile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ int main( int argc, char *argv[] ){
med->H5_Lstar[ med->H5_nT ][i] = MagEphemInfo->Lstar[i];
med->H5_DriftShellType[ med->H5_nT ][i] = MagEphemInfo->DriftOrbitType[i];
med->H5_Sb[ med->H5_nT ][i] = MagEphemInfo->Sb[i];
med->H5_I[ med->H5_nT ][i] = MagEphemInfo->I[i];
med->H5_I_data[ med->H5_nT ][i] = MagEphemInfo->I_data[i];
med->H5_Bm[ med->H5_nT ][i] = MagEphemInfo->Bm[i];

Ek = 1.0; // MeV
Expand All @@ -899,13 +899,13 @@ int main( int argc, char *argv[] ){
med->H5_Kappa[ med->H5_nT ][i] = sqrt( MagEphemInfo->RofC*Re*1e3/rg );


if ( (MagEphemInfo->Bm[i]>0.0)&&(MagEphemInfo->I[i]>=0.0) ) {
med->H5_K[ med->H5_nT ][i] = 3.16227766e-3*MagEphemInfo->I[i]*sqrt(MagEphemInfo->Bm[i]);
if ( (MagEphemInfo->Bm[i]>0.0)&&(MagEphemInfo->I_data[i]>=0.0) ) {
med->H5_K[ med->H5_nT ][i] = 3.16227766e-3*MagEphemInfo->I_data[i]*sqrt(MagEphemInfo->Bm[i]);
} else {
med->H5_K[ med->H5_nT ][i] = LGM_FILL_VALUE;
}
if (MagEphemInfo->I[i]>=0.0) {
med->H5_L[ med->H5_nT ][i] = LFromIBmM_McIlwain(MagEphemInfo->I[i], MagEphemInfo->Bm[i], MagEphemInfo->Mused );
if (MagEphemInfo->I_data[i]>=0.0) {
med->H5_L[ med->H5_nT ][i] = LFromIBmM_McIlwain(MagEphemInfo->I_data[i], MagEphemInfo->Bm[i], MagEphemInfo->Mused );
} else {
med->H5_L[ med->H5_nT ][i] = LGM_FILL_VALUE;
}
Expand Down
10 changes: 5 additions & 5 deletions Tools/MagEphemFromSpiceKernel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,7 @@ printf("sclkdp = %lf\n", sclkdp);
med->H5_Lstar[ med->H5_nT ][i] = MagEphemInfo->Lstar[i];
med->H5_DriftShellType[ med->H5_nT ][i] = MagEphemInfo->DriftOrbitType[i];
med->H5_Sb[ med->H5_nT ][i] = MagEphemInfo->Sb[i];
med->H5_I[ med->H5_nT ][i] = MagEphemInfo->I[i];
med->H5_I_data[ med->H5_nT ][i] = MagEphemInfo->I_data[i];
med->H5_Bm[ med->H5_nT ][i] = MagEphemInfo->Bm[i];

Ek = 1.0; // MeV
Expand All @@ -1724,13 +1724,13 @@ printf("sclkdp = %lf\n", sclkdp);
med->H5_Kappa[ med->H5_nT ][i] = sqrt( MagEphemInfo->RofC*Re*1e3/rg );


if ( (MagEphemInfo->Bm[i]>0.0)&&(MagEphemInfo->I[i]>=0.0) ) {
med->H5_K[ med->H5_nT ][i] = 3.16227766e-3*MagEphemInfo->I[i]*sqrt(MagEphemInfo->Bm[i]);
if ( (MagEphemInfo->Bm[i]>0.0)&&(MagEphemInfo->I_data[i]>=0.0) ) {
med->H5_K[ med->H5_nT ][i] = 3.16227766e-3*MagEphemInfo->I_data[i]*sqrt(MagEphemInfo->Bm[i]);
} else {
med->H5_K[ med->H5_nT ][i] = LGM_FILL_VALUE;
}
if (MagEphemInfo->I[i]>=0.0) {
med->H5_L[ med->H5_nT ][i] = LFromIBmM_McIlwain(MagEphemInfo->I[i], MagEphemInfo->Bm[i], MagEphemInfo->Mused );
if (MagEphemInfo->I_data[i]>=0.0) {
med->H5_L[ med->H5_nT ][i] = LFromIBmM_McIlwain(MagEphemInfo->I_data[i], MagEphemInfo->Bm[i], MagEphemInfo->Mused );
} else {
med->H5_L[ med->H5_nT ][i] = LGM_FILL_VALUE;
}
Expand Down
10 changes: 5 additions & 5 deletions Tools/MagEphemFromTLE.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,7 +1677,7 @@ int tiii = 0;
med->H5_Lstar[ med->H5_nT ][i] = MagEphemInfo->Lstar[i];
med->H5_DriftShellType[ med->H5_nT ][i] = MagEphemInfo->DriftOrbitType[i];
med->H5_Sb[ med->H5_nT ][i] = MagEphemInfo->Sb[i];
med->H5_I[ med->H5_nT ][i] = MagEphemInfo->I[i];
med->H5_I_data[ med->H5_nT ][i] = MagEphemInfo->I_data[i];
med->H5_Bm[ med->H5_nT ][i] = MagEphemInfo->Bm[i];

Ek = 1.0; // MeV
Expand All @@ -1696,13 +1696,13 @@ int tiii = 0;
med->H5_Kappa[ med->H5_nT ][i] = sqrt( MagEphemInfo->RofC*Re*1e3/rg );


if ( (MagEphemInfo->Bm[i]>0.0)&&(MagEphemInfo->I[i]>=0.0) ) {
med->H5_K[ med->H5_nT ][i] = 3.16227766e-3*MagEphemInfo->I[i]*sqrt(MagEphemInfo->Bm[i]);
if ( (MagEphemInfo->Bm[i]>0.0)&&(MagEphemInfo->I_data[i]>=0.0) ) {
med->H5_K[ med->H5_nT ][i] = 3.16227766e-3*MagEphemInfo->I_data[i]*sqrt(MagEphemInfo->Bm[i]);
} else {
med->H5_K[ med->H5_nT ][i] = LGM_FILL_VALUE;
}
if (MagEphemInfo->I[i]>=0.0) {
med->H5_L[ med->H5_nT ][i] = LFromIBmM_McIlwain(MagEphemInfo->I[i], MagEphemInfo->Bm[i], MagEphemInfo->Mused );
if (MagEphemInfo->I_data[i]>=0.0) {
med->H5_L[ med->H5_nT ][i] = LFromIBmM_McIlwain(MagEphemInfo->I_data[i], MagEphemInfo->Bm[i], MagEphemInfo->Mused );
} else {
med->H5_L[ med->H5_nT ][i] = LGM_FILL_VALUE;
}
Expand Down
28 changes: 14 additions & 14 deletions libLanlGeoMag/ComputeI_FromMltMlat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ double ComputeI_FromMltMlat1( double Bm, double MLT, double mlat, double *r, dou

int reset=1, reset2;

double I, Phi, cl, sl, rat, SS1, SS2, SS, Sn, Ss, Htry, Hdid, Hnext, Bs, Be, s, sgn;
double I1, Phi, cl, sl, rat, SS1, SS2, SS, Sn, Ss, Htry, Hdid, Hnext, Bs, Be, s, sgn;
Lgm_Vector w, u, Pmirror1, Pmirror2, v1, v2, v3, Bvec, P, Ps, u_scale, Bvectmp, Ptmp;
double stmp, Btmp;

Expand All @@ -52,8 +52,8 @@ double ComputeI_FromMltMlat1( double Bm, double MLT, double mlat, double *r, dou
* Couldnt get a valid Bm. (The bracket is pretty huge,so
* we probably ought to believe there really isnt a valid one.)
*/
if (LstarInfo->VerbosityLevel > 1) printf("\t%sNo Bm found: setting I to 9e99%s\n", LstarInfo->PreStr, LstarInfo->PostStr);
I = 9e99;
if (LstarInfo->VerbosityLevel > 1) printf("\t%sNo Bm found: setting I1 to 9e99%s\n", LstarInfo->PreStr, LstarInfo->PostStr);
I1 = 9e99;

} else {

Expand Down Expand Up @@ -195,7 +195,7 @@ double ComputeI_FromMltMlat1( double Bm, double MLT, double mlat, double *r, dou
*
* Trace from Pm_North to Pm_South
*/
I = 9e99;
I1 = 9e99;
//LstarInfo->mInfo->Hmax = 10.0;
//LstarInfo->mInfo->Hmax = 0.1;
LstarInfo->mInfo->Hmax = 0.1;
Expand Down Expand Up @@ -306,18 +306,18 @@ if (0==1){
/*
* Do I integral with interped integrand.
*/
//printf("I = %g\n", I);
I = Iinv_interped( LstarInfo->mInfo );
//printf("I = %g Sm_South, Sm_North = %g %g\n", I, LstarInfo->mInfo->Sm_South, LstarInfo->mInfo->Sm_North);
// if (LstarInfo->VerbosityLevel > 1) printf("\t\t%s Integral Invariant, I (interped): %15.8g I-I0: %15.8g [a,b]: %.15g %.15g mlat: %12.8lf (nCalls = %d)%s\n", LstarInfo->PreStr, I, I-I0, LstarInfo->mInfo->Sm_South, LstarInfo->mInfo->Sm_North, mlat, LstarInfo->mInfo->Lgm_n_I_integrand_Calls, LstarInfo->PostStr );
//printf("I = %g\n", I1);
I1 = Iinv_interped( LstarInfo->mInfo );
Comment thread
drsteve marked this conversation as resolved.
//printf("I = %g Sm_South, Sm_North = %g %g\n", I1, LstarInfo->mInfo->Sm_South, LstarInfo->mInfo->Sm_North);
// if (LstarInfo->VerbosityLevel > 1) printf("\t\t%s Integral Invariant, I (interped): %15.8g I-I0: %15.8g [a,b]: %.15g %.15g mlat: %12.8lf (nCalls = %d)%s\n", LstarInfo->PreStr, I1, I1-I0, LstarInfo->mInfo->Sm_South, LstarInfo->mInfo->Sm_North, mlat, LstarInfo->mInfo->Lgm_n_I_integrand_Calls, LstarInfo->PostStr );
if (LstarInfo->VerbosityLevel > 1) {
printf("\t\t%s mlat: %13.6g I: %13.6g I0: %13.6g I-I0: %13.6g [Sa,Sb]: %.8g %.8g (nCalls = %d)%s\n", LstarInfo->PreStr, mlat, I, I0, I-I0, LstarInfo->mInfo->Sm_South, LstarInfo->mInfo->Sm_North, LstarInfo->mInfo->Lgm_n_I_integrand_Calls, LstarInfo->PostStr );
printf("\t\t%s mlat: %13.6g I1: %13.6g I0: %13.6g I1-I0: %13.6g [Sa,Sb]: %.8g %.8g (nCalls = %d)%s\n", LstarInfo->PreStr, mlat, I1, I0, I1-I0, LstarInfo->mInfo->Sm_South, LstarInfo->mInfo->Sm_North, LstarInfo->mInfo->Lgm_n_I_integrand_Calls, LstarInfo->PostStr );
}
FreeSpline( LstarInfo->mInfo );

} else {

I = 9e99;
I1 = 9e99;

}

Expand All @@ -332,19 +332,19 @@ if (0==1){
/*
* Do full blown I integral.
*/
I = Iinv( LstarInfo->mInfo );
if (LstarInfo->VerbosityLevel > 1) printf("\t\t%s Integral Invariant, I (full integral): %15.8g I-I0: %15.8g mlat: %12.8lf (nCalls = %d)%s\n", LstarInfo->PreStr, I, I-I0, mlat, LstarInfo->mInfo->Lgm_n_I_integrand_Calls, LstarInfo->PostStr );
I1 = Iinv( LstarInfo->mInfo );
if (LstarInfo->VerbosityLevel > 1) printf("\t\t%s Integral Invariant, I1 (full integral): %15.8g I1-I0: %15.8g mlat: %12.8lf (nCalls = %d)%s\n", LstarInfo->PreStr, I1, I1-I0, mlat, LstarInfo->mInfo->Lgm_n_I_integrand_Calls, LstarInfo->PostStr );
}

} else {
I = 9e99;
I1 = 9e99;
}

}




return( I );
return( I1 );

}
Loading
Loading