serial_panel: allow the serial panel to communicate on different ports not just the default - #140
Merged
joshanne merged 1 commit intoAug 31, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the Serial Forwarding panel to let users choose which target serial/UART device to communicate with (instead of always using the default), improving flexibility for nodes exposing multiple serial ports.
Changes:
- Added a “Target Serial”
QComboBoxto select the target serial device (Default / Serial 0–5). - Wired the selected target device into
DroneCANSerialconstruction. - Added a callback intended to update the target device on an existing tunnel when the selection changes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…s not just default
joshanne
force-pushed
the
pr/serial-panel-target-device-selection
branch
from
August 27, 2026 01:33
a1f53fb to
e45e55a
Compare
patrickelectric
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most people using the serial panel, they most likely only require default, but I required a number of different ports that were otherwise not selectable without either source or parameter changes.