Updating the main branch in Daniel's root repo with my changes after completing 2606.30729 - #3
Conversation
add ISCO bounds
Merge main branch updates into rotBS
Update main branch in my fork with the rotating BS stuff
…nto from_config_reader
|
Starting review. Not ready to merge yet. |
SeppeStaelens
left a comment
SeppeStaelens
left a comment
There was a problem hiding this comment.
Mostly comments to myself, to clean and fix before it can sensibly be pushed to the main repo.
| AllDiagSettings["EquatorialEmission"].LookupValue("ISCOLowerBound", iscolowerbound); | ||
| AllDiagSettings["EquatorialEmission"].LookupValue("ISCOUpperBound", iscoupperbound); | ||
| } | ||
| else |
There was a problem hiding this comment.
The fallback logic needs to be checked here: at the moment it always falls back to GeneralCircularRadial
| real upperbound{1000.0}; | ||
| real lowerbound{m_ISCOlowerbound}; | ||
| real upperbound{m_ISCOupperbound}; | ||
| const SphericalHorizonMetric *sphermetric = dynamic_cast<const SphericalHorizonMetric *>(m_theMetric); |
There was a problem hiding this comment.
This is perhaps something I need to look at as well: since I now made ISCO lower and upper bound configurable, it is perhaps not logical that these parameters will get overwritten if the metric is a SphericalHorizonMetric
| BicubicSplineInterpolator *m_lInterpolator; | ||
| BicubicSplineInterpolator *m_gInterpolator; | ||
| BicubicSplineInterpolator *m_OmegaInterpolator; | ||
|
|
There was a problem hiding this comment.
The parameter L is actually outdated: should maybe get rid of it first
| @@ -1,12 +1,24 @@ | |||
| add_executable(test_integrator test_integrator.cpp) | |||
| add_executable(test_einstein_ring test_einstein_ring.cpp) | |||
| add_executable(test_rotating_boson_star_geodesic test_rotating_boson_star_geodesic.cpp) | |||
There was a problem hiding this comment.
I probably need to remove the rotating BS tests if the files are not publicly available
| ## | ||
| ## Get latest from https://github.com/github/gitignore/blob/master/VisualStudio.gitignore | ||
|
|
||
| # Additional |
There was a problem hiding this comment.
Move these outside of .gitignore, as these are all currently in the repo. Either move to exclude or prune
1 participant
Lengthy PR to start reviewing changes made to the FOORT code after finishing 2606.30729. On the top level, this includes
This PR will likely stay open for a while, to review the changes in some more detail. After review, a large codebase review will be carried out with the help of some AI tool, to catch any final issues.