feat: Add debug switch for intermediate growth tests in CMPB - #46
Open
dyrpsf wants to merge 1 commit into
Open
Conversation
Resolves inline TODO by wrapping intermediate growth tests in a debug toggle.
There was a problem hiding this comment.
Pull request overview
This PR updates the CMPB workflow entry point to support an optional debug mode for running intermediate growth tests, reducing default runtime while preserving final growth reporting.
Changes:
- Added a
debug_growth: bool = Falseparameter tosrc/specimen/cmpb/workflow.py:run(). - Wrapped intermediate
between_growth_test()calls behindif debug_growth:checks while keeping the final growth test unconditional. - Performed minor formatting/cleanup (imports, string quotes, line wrapping) consistent with the existing code style.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ################################################################################ | ||
|
|
||
|
|
||
| # @TODO Add debug switches to test growth on every step (Maybe also on full medium?) -> Maybe as entry point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an inline
@TODOleft by @GwennyGit insrc/specimen/cmpb/workflow.pyregarding the inclusion of debug switches to test growth at every step.Previously, the CMPB workflow ran computationally expensive growth simulations at five intermediate stages unconditionally. This update introduces a
debug_growthtoggle to therun()entry point to optimize standard runtime, while preserving the ability to generate those intermediate reports when needed.Tagging @cb-Hades for review as the primary maintainer!
Key Changes
debug_growth: bool = Falseto therun()function signature.between_growth_test()calls (after draft, gapfill, duplicate removal, ModelPolisher, and EGCs) insideif debug_growth:checks.