-
-
Notifications
You must be signed in to change notification settings - Fork 66
ISSUE-1616: Upgrade to node 16 #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ZeldaZach
merged 27 commits into
dr4fters:master
from
keeler:ISSUE-1616-upgrade-off-node-12
Jun 4, 2022
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d267051
chore: node 12.16.3 -> 16.15.0
keeler da19113
chore: npm audit fix
keeler 9e00685
chore: Add .nvmrc
keeler d636bfb
feat: Add Makefile
keeler bf5ca74
chore: Github workflow use npm ci
keeler 5fbc461
wip: Attempt at better docker build caching
keeler b62b9d3
docs: Makefile help target
keeler 92327e9
feat: Don't need git in docker image
keeler cfeb1bf
refactor: CI pipeline use docker image
keeler d37a9f3
fix: Hide news if no message of the day
keeler 528a1c0
fix: Broke editorconfig
keeler 2bddf77
fix: Docker env from arg invalidates cache
keeler d7f1a04
fix: Shallow clone doesn't include tags
keeler 2700269
fix: Use fetch-depth 0 to get tag history
keeler 45ed0da
feedback: Undo Dockerfile & CI refactor
keeler d5ffbdd
chore: Update node in github action
keeler 3065591
feedback: Direct developers to install Node 16 not 12
keeler 6e4aa08
feedback: Use lts-alpine to keep image version up-to-date
keeler 395d99e
feedback: Current LTS is 16.15.1
keeler cbab064
npm ci in ci
tooomm aebd8bf
do not fail-fast on single job failure
tooomm 19ec2a3
chore: Dependency '@hapi/joi' -> 'joi'
keeler 113aef9
hack: sed -i 's/git+ssh/git+https/g' package-lock.json
keeler b90bbb5
Revert "hack: sed -i 's/git+ssh/git+https/g' package-lock.json"
keeler 5083990
hack: Do sed trick conditionally in CI pipeline
keeler 287f4e2
feedback: Github actions support 'if' conditions
keeler ecede51
fix gha
tooomm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v12 | ||
| 16.15.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.