-
Notifications
You must be signed in to change notification settings - Fork 576
Add client-side WebHttpBinding support (closes #1413, #46) #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
afifi-ins
wants to merge
20
commits into
dotnet:main
Choose a base branch
from
afifi-ins:feature/webhttpbinding-porting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ae73e48
Scaffold System.ServiceModel.Web package
Copilot 66b26dc
Port UriTemplate cluster from .NET Framework reference source
Copilot 01301cd
Suppress SYSLIB0051 on UriTemplateMatchException serialization ctor
Copilot 87a6a47
Demote MSB3243 to message in System.ServiceModel.Web.Tests csproj
Copilot 16e9b64
Port Phase 3: encoding plumbing from CoreWCF.WebHttp v1.8.0
Copilot 8237982
Port Phase 4: attributes, faults, web operation context
Copilot 58b6f86
Port Phase 5: WebHttpBinding, WebHttpBehavior, client-side dispatchers
Copilot 2df9f9b
Port WebChannelFactory<T> + add Phase 6 test infrastructure
Copilot 4cd4996
Bump WebHttpBinding from not-supported to partially-supported
Copilot d521963
Add Binding.WebHttp.IntegrationTests to System.ServiceModel.sln
Copilot 8cd0646
Fix WebHttpBehavior.ApplyClientBehavior: wire up real client formatters
Copilot 12068f7
Fix WebMessageEncodingBindingElement to register itself in BindingPar…
afifi-ins 39ffadc
Avoid trailing slash on registered URI when endpoint Address is empty
afifi-ins 0622b41
Don't materialize unported raw encoder in IsContentTypeSupported
afifi-ins 42209c4
Honour WebMessageFormat.Json for reply formatter selection
afifi-ins 98ec5dd
Gate WebHttp outerloop tests to the CoreWCF self-host leg
afifi-ins 0604580
Use C# 5-compatible member syntax in WebHttp IIS test host
mconnew f34d2bc
Expose AllowCookies, ProxyAddress, UseDefaultWebProxy, BypassProxyOnL…
afifi-ins 2e64a7d
Map ProxyAuthenticationScheme from Security.Transport.ProxyCredential…
afifi-ins db4e189
Guard WebHttpBinding.BuildChannelFactory against InheritedFromHost on…
afifi-ins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/System.Private.ServiceModel/tests/Common/Scenarios/Endpoints.WebHttp.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| // Endpoints addresses for WebHttp (REST) test services. Partial extension to | ||
| // Endpoints (declared partial in tests/Common/Scenarios/Endpoints.cs). | ||
| public static partial class Endpoints | ||
| { | ||
| #region WebHttp Addresses | ||
| public static string HttpBaseAddress_WebHttp | ||
| => GetEndpointAddress("WebHttp.svc/"); | ||
|
|
||
| public static string HttpBaseAddress_WebHttp_EchoGet | ||
| => GetEndpointAddress("WebHttp.svc/EchoWithGet"); | ||
|
|
||
| public static string HttpBaseAddress_WebHttp_EchoGetJson | ||
| => GetEndpointAddress("WebHttp.svc/EchoWithGetJson"); | ||
|
|
||
| public static string HttpBaseAddress_WebHttp_EchoPost | ||
| => GetEndpointAddress("WebHttp.svc/EchoWithPost"); | ||
|
|
||
| public static string HttpBaseAddress_WebHttp_EchoPostJson | ||
| => GetEndpointAddress("WebHttp.svc/EchoWithPostJson"); | ||
|
|
||
| public static string HttpBaseAddress_WebHttp_EchoGetPath | ||
| => GetEndpointAddress("WebHttp.svc/EchoWithGetPath"); | ||
| #endregion | ||
| } |
25 changes: 25 additions & 0 deletions
25
...vate.ServiceModel/tests/Scenarios/Binding/WebHttp/Binding.WebHttp.IntegrationTests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), certtest.props))\certtest.props" /> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>$(ScenarioTestTargetFrameworks)</TargetFrameworks> | ||
| <CLSCompliant>false</CLSCompliant> | ||
| <IsTestProject>true</IsTestProject> | ||
| <IsPackable>false</IsPackable> | ||
| <LangVersion>9.0</LangVersion> | ||
| <!-- Same warning suppressions as the impl project: type-name collisions | ||
| (SR, BufferedMessage, etc.) between our new System.ServiceModel.Web | ||
| and Primitives/Http internals exposed via InternalsVisibleTo. --> | ||
| <NoWarn>$(NoWarn);CS0105;CS0108;CS0436;MSB3243</NoWarn> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\..\..\System.ServiceModel.Primitives\src\System.ServiceModel.Primitives.csproj" /> | ||
| <ProjectReference Include="..\..\..\..\..\System.ServiceModel.Http\src\System.ServiceModel.Http.csproj" /> | ||
| <ProjectReference Include="..\..\..\..\..\System.ServiceModel.Web\src\System.ServiceModel.Web.csproj" /> | ||
| <ProjectReference Include='$(WcfScenarioTestCommonProj)' /> | ||
| <ProjectReference Include="$(WcfInfrastructureCommonProj)" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
| </Project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be modifying this file as it's the features released with a really old version.