dotnet-svcutil: write generated json file with relative path for referenced assembly.#5500
Open
imcarolwang wants to merge 2 commits into
Open
dotnet-svcutil: write generated json file with relative path for referenced assembly.#5500imcarolwang wants to merge 2 commits into
imcarolwang wants to merge 2 commits into
Conversation
imcarolwang
marked this pull request as ready for review
April 17, 2024 06:28
|
Any estimations for the merge? ;-) |
imcarolwang
commented
Sep 6, 2024
imcarolwang
commented
Sep 6, 2024
imcarolwang
force-pushed
the
issue5495
branch
from
September 18, 2024 06:01
8ffb4d7 to
33d576b
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
imcarolwang
force-pushed
the
issue5495
branch
from
October 18, 2024 12:10
d1c3b3e to
1530698
Compare
imcarolwang
changed the title
imcarolwang
force-pushed
the
issue5495
branch
2 times, most recently
from
October 24, 2024 09:38
9c7c503 to
3f52c4d
Compare
Follow-up to the dotnet-svcutil fix that writes referenced assembly paths relative to the params.json file (issue dotnet#5495): - ReuseIXmlSerializableType: this test was added on main after PR dotnet#5500 was opened; update its baseline params.json so the CommonTypes.dll reference matches the relative path now emitted by svcutil. - MultiTargetTypeReuse: bump TypeReuseClient TFMs from net6.0;net7.0 (both out of support) to net10.0;net8.0, and update the baseline csproj and params.json (bin/Debug/net10.0/BinLib.dll) accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #5495.
Write referenced assembly name instead of absolute path to the generated parameters json file, corresponding to the change, recalculate references base on project dependencies for update operation, update related test as well.