Add OpenTelemetry.PersistentStorage.FileSystem to source-build-assets#1741
Merged
Merged
Conversation
Adds OpenTelemetry.PersistentStorage.FileSystem and its required dependency OpenTelemetry.PersistentStorage.Abstractions from the opentelemetry-dotnet-contrib repo, following the pattern used by the existing Instrumentation.Http and Instrumentation.Runtime packages. The pinned submodule commit's PersistentStorage sources are identical to the PersistentStorage-1.0.3 release (only CHANGELOG.md differs), so both packages build as 1.0.3 with AssemblyVersion = FileVersion = 1.0.3.1043, matching the Microsoft-shipped packages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds OpenTelemetry.PersistentStorage.Abstractions and OpenTelemetry.PersistentStorage.FileSystem as source-built external packages from the existing opentelemetry-dotnet-contrib submodule, aligning their version metadata with Microsoft-shipped packages for validation.
Changes:
- Added release-version properties for the two new OpenTelemetry PersistentStorage packages.
- Added file/assembly version override metadata +
FileVersionValidationPackageentries for both packages. - Added restore/pack steps to build the two new packages (packing Abstractions before FileSystem).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/Versions.props | Adds release-version properties for the two new PersistentStorage packages. |
| src/externalPackages/projects/opentelemetry-dotnet-contrib.props | Adds version override metadata and validation items for the new packages. |
| src/externalPackages/projects/opentelemetry-dotnet-contrib.proj | Adds restore/pack steps and per-package version args for the new packages. |
mthalman
approved these changes
Jul 8, 2026
This was referenced Jul 11, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
OpenTelemetry.PersistentStorage.FileSystem(and its required dependencyOpenTelemetry.PersistentStorage.Abstractions) from theopentelemetry-dotnet-contribrepo to source-build-assets, in preparation for an upcoming change in dotnet/sdk. This follows the exact pattern already used for the existingOpenTelemetry.Instrumentation.HttpandOpenTelemetry.Instrumentation.Runtimepackages built from the same submodule.Changes
eng/Versions.props— addedOpenTelemetryDotNetContribPersistentStorageAbstractionsReleaseVersionandOpenTelemetryDotNetContribPersistentStorageFileSystemReleaseVersion(both1.0.3).src/externalPackages/projects/opentelemetry-dotnet-contrib.props— added AssemblyVersion / FileVersion-revision override properties (both1.0.3.1043, revision1043) and twoFileVersionValidationPackageitems so the metadata-update tool andExternalPackageTestsvalidate them against the Microsoft-shipped packages.src/externalPackages/projects/opentelemetry-dotnet-contrib.proj— added restore + pack steps for Abstractions (packed first, since FileSystem references it) and FileSystem.The submodule pointer is unchanged.
Why version 1.0.3
The pinned submodule commit (
b89c765, theInstrumentation.Runtime-1.15.1tag) contains PersistentStorage sources that are identical to thePersistentStorage-1.0.3release — the diff between them touches onlyCHANGELOG.md. The later1.1.0tag has real code changes, so1.0.3is the correct version for this commit.Validation
1.0.3packages ship withAssemblyVersion = FileVersion = 1.0.3.1043for both assemblies.OpenTelemetry.PersistentStorage.Abstractions.1.0.3.nupkgandOpenTelemetry.PersistentStorage.FileSystem.1.0.3.nupkg1.0.3.1043acrossnet462andnetstandard2.0FileSystemcorrectly depends onOpenTelemetry.PersistentStorage.Abstractions 1.0.3Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com