Avoid stripping IL of non-async Task-returning methods#129884
Open
jakobbotsch wants to merge 1 commit into
Open
Avoid stripping IL of non-async Task-returning methods#129884jakobbotsch wants to merge 1 commit into
jakobbotsch wants to merge 1 commit into
Conversation
The IL of these may be needed at runtime to compile async versions.
Contributor
There was a problem hiding this comment.
Pull request overview
This change updates ReadyToRun IL body stripping so the compiler retains real IL for methods whose IL may be needed at runtime (notably synchronous Task/ValueTask-returning methods that can have async variants), instead of replacing their bodies with the minimal throwing stub when --strip-il-bodies is enabled.
Changes:
- Replaces the previous “non-generic only” strip condition with a helper (
MayNeedILAtRuntime) that centralizes the decision. - Preserves IL for generic methods/types (existing behavior) and additionally for non-async
Task/ValueTask-returning methods.
Member
Author
|
Once the crossgen2 support makes it in we could also consider being a bit more precise -- we can strip the IL body if we have compiled both the async and non-async variants. |
jkotas
added
runtime-async
area-ReadyToRun
and removed
area-crossgen2-coreclr
jkotas
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IL of these may be needed at runtime to compile async versions.