Remove concurrent verify_soh_segment_list call in background_sweep#129873
Open
janvorli wants to merge 1 commit into
Open
Remove concurrent verify_soh_segment_list call in background_sweep#129873janvorli wants to merge 1 commit into
janvorli wants to merge 1 commit into
Conversation
The removed call site runs inside the concurrent background sweep loop, after restart_EE(), when allocations and SOH segment-list mutations can run on other threads. verify_soh_segment_list assumes stable list topology while it walks generation links, so calling it in this window can observe in-flight updates and report false verification failures. We keep verification at synchronized GC phase boundaries and remove only this racy in-loop invocation.
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an in-loop call to verify_soh_segment_list() from gc_heap::background_sweep() to avoid racy heap verification while the EE is restarted and concurrent allocations may be mutating the SOH segment list.
Changes:
- Removed
verify_soh_segment_list()invocation from the concurrent background sweep loop (segment-to-segment progression).
kkokosa
approved these changes
Jun 26, 2026
Member
|
is this a regression from 10? |
Member
Author
|
@mangod9 I don't know, I haven't checked if it was failing before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removed call site runs inside the concurrent background sweep loop, after restart_EE(), when allocations and SOH segment-list mutations can run on other threads. verify_soh_segment_list assumes stable list topology while it walks generation links, so calling it in this window can observe in-flight updates and report false verification failures. We keep verification at synchronized GC phase boundaries and remove only this racy in-loop invocation.
Close #129723