Remove support for 8 unused secret-manager types#6646
Draft
garath wants to merge 1 commit into
Draft
Conversation
Removes secret types that are not referenced by any .vault-config manifest across the dnceng/internal ADO project (audited: dotnet-arcade, dotnet-arcade-services, dotnet-dnceng, dotnet-helix-machines, dotnet-helix-service, dotnet-release): - ad-application - maestro-access-token - dotnetstatusweb-access-token - sql-connection-string - kusto-connection-string (depended on ad-application; also unused) - base64-encoder - azure-storage-account-sas-uri - azure-storage-container-sas-token Registration is reflection-based (AddNamedFromAssembly scans [Name] attributes), so deleting the type classes fully deregisters them. Also removes the orphaned DotNetStatusWebAccessTokenTests and the corresponding Readme documentation sections. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f4dd4f39-9896-49e1-a690-c9930af65ebd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes secret-manager secret types that are not referenced by any .vault-config manifest across the repositories in the
dnceng/internalADO project.Audit
Searched every
.vault-configmanifest in: dotnet-arcade, dotnet-arcade-services, dotnet-dnceng, dotnet-helix-machines, dotnet-helix-service, dotnet-release. None of the following types were used by any secret:ad-applicationmaestro-access-tokendotnetstatusweb-access-tokensql-connection-stringkusto-connection-string(depended onad-application; also unused)base64-encoderazure-storage-account-sas-uriazure-storage-container-sas-tokenChanges
SecretTypeclasses. Registration is reflection-based (AddNamedFromAssemblyscans[Name]attributes), so deleting the classes fully deregisters them.DotNetStatusWebAccessTokenTests.Readme.mddocumentation sections.Validation
dotnet buildsucceeds (0 warnings, 0 errors).