Run test project target frameworks in parallel#17161
Open
Evangelink wants to merge 6 commits into
Open
Conversation
Dispatch each target framework through a parallel inner MSBuild invocation and add a barrier-based regression test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed12a139-3ab6-45cc-8f6f-e01edba82614
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Arcade SDK test infrastructure so that multi-targeted test projects run each target framework as a separate inner MSBuild invocation, enabling those TFM runs to be scheduled in parallel (addressing #16581).
Changes:
- Switch
Test/IntegrationTestto dispatch into_InnerRunTestsor_OuterRunTests(per single-/multi-targeting) and run inner builds withBuildInParallel="true". - Add a functional regression test asset and xUnit test that deadlocks/fails if TFMs are executed serially.
- Plumb
FileWritesfrom inner test runs back to the outer target for correct output tracking.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.DotNet.Arcade.Sdk/tools/Tests.targets | Runs multi-target test TFMs as parallel inner MSBuild builds via _OuterRunTests and _InnerRunTests. |
| src/Microsoft.DotNet.Arcade.Sdk.Tests/testassets/ParallelTestTfms/ParallelTestTfms.proj | New test asset project to validate parallel TFM execution. |
| src/Microsoft.DotNet.Arcade.Sdk.Tests/testassets/ParallelTestTfms/eng/Parallel/Parallel.targets | Custom test runner targets implementing a barrier to fail when TFMs run serially. |
| src/Microsoft.DotNet.Arcade.Sdk.Tests/ParallelTestTfmsTests.cs | New regression test that executes the asset and asserts success/expected artifacts. |
| src/Microsoft.DotNet.Arcade.Sdk.Tests/Microsoft.DotNet.Arcade.Sdk.Tests.csproj | Copies Tests.targets into the specific test asset folder so the asset uses the PR’s version. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed12a139-3ab6-45cc-8f6f-e01edba82614
Use writable Helix paths for functional test fixtures, simplify inner-build item construction, and normalize barrier paths across platforms. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed12a139-3ab6-45cc-8f6f-e01edba82614
Treat empty Helix roots as unset and make the fake test runner produce and track its declared stdout artifact. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed12a139-3ab6-45cc-8f6f-e01edba82614
Evangelink
enabled auto-merge
July 22, 2026 11:00
Preserve architecture inference and validation within each parallel inner TFM test build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ed12a139-3ab6-45cc-8f6f-e01edba82614
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16581
Validation
Build.cmd -configuration Release -test