fix(layout): Rotate bépo keybindings in dirvish#8214
Open
gagbo wants to merge 1 commit into
Open
Conversation
hlissner
added
is:bug
gagbo
marked this pull request as ready for review
February 24, 2025 18:43
Member
Author
|
Sadly, it's getting increasingly obvious that I won't have the bandwidth to propoerly retest this. I'd go to merge it as is, and re-open lthe attached issue if it reappears |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #8129
Dirvish wasn’t taken care of in the bépo-specific rotations, and ended up having issues around the binding for the
skeyThe PR is a draft because it’s untested yet (I don’t write in Bépo so testing actually takes more time than writing the code)
My changes are visual; I've included before and after screenshots.finishtest it.