Skip to content

fix: handle failed embed fetches and falsy cached() returns #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Diawhiz wants to merge 3 commits into from
Closed

fix: handle failed embed fetches and falsy cached() returns #2741

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e720674
fix: handle failed embed fetches and falsy cached() returns
Diawhiz Jun 5, 2026
5068f34
Merge branch 'develop' into develop
Diawhiz Jun 5, 2026
fcacafb
Merge branch 'develop' into develop
Diawhiz Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/util/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function cached(fn) {
return function (str) {
const key = isPrimitive(str) ? str : JSON.stringify(str);
const hit = cache[key];
return hit || (cache[key] = fn(str));
return hit !== undefined ? hit : (cache[key] = fn(str));
};
}

Expand Down
Loading