Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The global mirror-4 disable breaks fallback behavior, and the legacy state change does not affect driver installation.
Review effort: Lite
Findings: 1
What changed in this PR
Updates Windows 8.1 setup to avoid explicit VirtIO GPU installation and changes display/download configuration.
Changes:
- Removes VirtIO GPU installation from Windows 8.1 scripts.
- Changes the legacy VGA state to
vmware. - Updates DXVK to 3.0.2 and disables mirror 4.
| File | Summary |
|---|---|
src/legacy.sh |
Changes the legacy VGA state; the change has no runtime effect on driver installation. |
src/define.sh |
Disables mirror 4; the unconditional return removes a general fallback. |
Dockerfile |
Updates the DXVK version. |
assets/win81x64.cmd |
Removes VirtIO GPU installation. |
assets/win81x64-enterprise.cmd |
Removes VirtIO GPU installation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| [[ "${lang,,}" != "en" && "${lang,,}" != "en-us" ]] && return 0 | ||
|
|
||
| return 0 # Disable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.