Revert "Temporary fix to let CouchDB replications go through the standard port - wmagent" - #10476
Closed
todor-ivanov wants to merge 2 commits into
Closed
Revert "Temporary fix to let CouchDB replications go through the standard port - wmagent"#10476todor-ivanov wants to merge 2 commits into
todor-ivanov wants to merge 2 commits into
Conversation
…dard port - wmagent" This reverts commit 0741ac1.
amaltaro
reviewed
May 21, 2021
amaltaro
left a comment
amaltaro
left a comment
Contributor
There was a problem hiding this comment.
@todor-ivanov I assume you are still investigating and working on this, right? Making this comment to get this review request out of my way.
Contributor
Author
|
Hi @amaltaro Yes indeed. But we decided to postpone this work until some more prioritized activities reach a more complete state. If you wish I can renew my effort immediately! |
Contributor
|
I believe Imran will resume token-based testbed only after June 8th (production deployment). So we can likely wait to get closer and keep our focus in python3 related issues, IMO. |
Contributor
|
This is no longer needed (wmagent 1.4.7 branch), closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0741ac1.
Fixes #10452
Status
Testing
Description
While testing the migration of all machine generated traffic to port 8443 for WMAgent we noticed that the CouchDB replication was broken for WMAgent. I remember previously this was properly solved with those changes in my environment, so my suspicion is this may turn out to be either a deployment procedure issue, like a need of port 8443 to be manually opened on the central services side of the developers' testing deployment or we simply miss another spot in the code that the forwarding also needs to happen.
I need the current PR in order to be able to deploy an agent (by patching it at deployment time) with the supposedly broken piece of code, so I can observe where it breaks.
Is it backward compatible (if not, which system it affects?)
NO
Related PRs
#10453
External dependencies / deployment changes
Still to be added here.