Repository navigation
Conversation
tutozz
force-pushed
the
ad-volume
branch
2 times, most recently
from
September 8, 2026 18:16
339acb7 to
487064d
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Muting an ad cuts the sound dead, and I find that sudden silence more jarring than the ad. I'd rather drop the volume to a few percent and keep a floor.
Adds an optional
ad_volume(0-100). When set, an ad drops the volume to that value instead of flipping the mute flag, and the volume in place before the ad is restored when it ends. Left unset, nothing changes.Three things it has to handle:
onVolumeChanged, so the restore point is saved once at the start of the ad instead of being read back fromvolume_state;getVolumeis sent once the lounge session is up - otherwise the first ad after connecting has nothing to come back to;Wired into both configurators and the template.
Running on an Apple TV (tvOS 26.6) with
ad_volumeset:loungeStatus->getVolume->onVolumeChanged {'volume': '100'}in 100 ms, then ads play at the low volume and 100 comes back when they end.