Option to not advertise upon startup - #27
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.38%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
|
hello? |
jd1
left a comment
There was a problem hiding this comment.
I switched to your branch and it works fine. I justed added some suggestion to the YAML example. I can't say much about the code, but I would be happy if @dmamontov could have a look.
|
Thanks for the review! Your changes have been committed. |
Co-authored-by: Johannes Dilli <jd1@users.noreply.github.com>
Co-authored-by: Johannes Dilli <jd1@users.noreply.github.com>
Co-authored-by: Johannes Dilli <jd1@users.noreply.github.com>
Probably won't work seeing as 2.x re-wrote a lot, but lets try it first
With some devices, it is preferable simply not to advertise at all the return of the ESP keyboard once it restarts.
This option enables users to choose that.
They can create a switch to turn advertisements off in this way: