Conversation
kroening
force-pushed
the
c++20
branch
4 times, most recently
from
August 11, 2026 10:31
cbab6a2 to
2a7200a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9156 +/- ##
========================================
Coverage 80.83% 80.83%
========================================
Files 1717 1716 -1
Lines 190069 190110 +41
Branches 73 74 +1
========================================
+ Hits 153647 153684 +37
- Misses 36422 36426 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MSVC defaults to the local codepage (cp1252) for the execution character set. The plain string literals with \uXXXX escapes that replace the formerly used u8 literals (which are no longer streamable in C++20) were therefore encoded as '?', mangling all Unicode output and failing unit and regression tests on both Windows jobs. Passing /utf-8 makes the source and execution character sets UTF-8, restoring the previous behaviour byte-for-byte. CaDiCaL 3.0.0's vivify.hpp uses std::tuple without including <tuple>, which libstdc++ 12 no longer provides transitively in C++20 mode, breaking check-ubuntu-22_04-make-clang. Extend the CaDiCaL patch to add the missing include.
C++20 considers reversed operands as overload candidates for == and !=. For a non-const member operator== the reversed candidate takes a const object and is therefore a different, ambiguous overload; clang 14 rejects such uses with -Wambiguous-reversed-operator, which broke check-ubuntu-22_04-make-clang. Making the operators const removes the ambiguity and is correct const-wise anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the build from C++17 to C++20.