Repository navigation
kinship and nell benchmark results for kgfm's - #463
Merged
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
also added Ultra-4g and 50g eval |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Resolve validation/test overlap handling and preserve configurable ULTRA checkpoint injection.
Review effort: Lite
Findings: None
What changed in this PR
Adds KGFM benchmark results for KINSHIP and NELL variants, including ULTRA checkpoint metadata, leakage handling, tests, and documentation.
Changes:
- Adds checkpoint selection and pretraining metadata.
- Adds split-overlap validation and regression tests.
- Documents benchmark results and reproduction guidance.
| File | Description |
|---|---|
tests/test_kgfm_zero_shot.py |
Tests leakage handling and checkpoint metadata. |
README.md |
Adds benchmark results and leakage notes. |
docs/kgfm_benchmarks.md |
Documents protocol, datasets, checkpoints, and reproduction. |
benchmarks/kgfm_zero_shot.py |
Adds overlap validation and checkpoint metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Demirrr
approved these changes
Sep 22, 2026
Demirrr
left a comment
Member
There was a problem hiding this comment.
Great PR. Thank you for runing experiments and adding the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @Louis-Mozart