Repository navigation
Route binders, static_funcs, data_struct and search diagnostics through logging - #661
Merged
Merged
Conversation
…gh logging save_owl_class_expressions re-raises instead of calling exit(1). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth and last of the straightforward
printto logger cleanup PRs (Improvements.md§3), after #656-#659.binders.py: 'No prediction found' is a warning; the DL-Learner output dump (type/first/len,####banners) becomes one debug message; the 'no solution found' banner becomes a warning.utils/static_funcs.py:verbalizemessages (missing deeponto/graphviz, no complex classes, images generated) use error/warning/info.data_struct.py: error prints in except handlers becomelogger.error/warning; the two 'invalid input ... batching' messages are now carried by theValueErrorthey preceded.search.py: only the two diagnostic spots (_get_top_n_nodeswrong key,get_most_promisingmissing node). The tree-display methods print on purpose and are untouched.save_owl_class_expressionscalledexit(1)after dumping debug output, killing the interpreter from library code. It now logs the details and re-raises the originalAttributeError.print:executor.py,experiments.py,scripts/run.py(experiment runners / CLI output), the tree-display methods, and spell_kit DOT output.Improvements.mdnow says so and lists the few files still worth reviewing individually (95 realprintcalls remain, most intentional); CHANGELOG updated.Local: test_static_funcs, test_search, test_data_struct, test_verbalizer, test_drill, test_nces_trainer, test_clip_dataset_inference pass (47); ruff
--select Fshows no undefined names.🤖 Generated with Claude Code