Repository navigation
Prune two Improvements.md duplication items already fixed on develop - #617
Merged
Merged
Conversation
PR #616 (tree_learner_refinement dedup) and PR #615 (quality_funcs dedup) each pruned their own item from Improvements.md's §2 Code duplication, but #616's branch was updated from develop mid-review via a merge commit (2acaa0f) that re-added both bullets instead of keeping them removed — a bad conflict resolution, not a revert of either fix. Both fixes are still present in the code (quality_funcs.py delegates to metrics.py's F1/Accuracy; TDL_refinement.fit()/create_training_data() are deduplicated against TDL via shared hooks). This just corrects the stale doc. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H4NxQxE3vqNs2DQBWVaFeM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improvements.md's §2 Code duplication in their branch commits.developvia a merge commit (2acaa0f), which re-added both bullets toImprovements.mdinstead of keeping them removed — a bad conflict resolution, not a revert of either fix. That merge landed ondevelopas part of Deduplicate TDL_refinement.fit() against TDL via shared template-method hooks #616.ontolearn/quality_funcs.pystill delegates tometrics.py'sF1/Accuracy.TDL_refinement.fit()/create_training_data()are still deduplicated againstTDLvia the shared_maybe_plot_embeddings/_fit_decision_tree/_report_and_plot/_finalize_predictionshooks.Test plan
ontolearn/quality_funcs.pyandontolearn/learners/tree_learner*.pyondevelopagainst the two PR descriptions to confirm both fixes are intact🤖 Generated with Claude Code
https://claude.ai/code/session_01H4NxQxE3vqNs2DQBWVaFeM