Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ date) and use that section as the basis for the GitHub release notes.
by default, matching the other learners. (#585)

### Fixed
- `ConceptAbstractSyntaxTreeBuilder._fix_mid_tokens_errors`/`_postprocess_tail_fix`/
`_enforce` repaired malformed token sequences via `random.choice(...)`, making
parser output non-deterministic across runs on identical input; replaced with
a deterministic (sorted) tie-break.
- `DRILLSearchTreePriorityQueue.get_top_n()` raised `AttributeError`/`TypeError`
on the never-assigned `self.refined_nodes` attribute; now builds its node
list from `self.nodes.values()`. (#605)
Expand Down
8 changes: 1 addition & 7 deletions Improvements.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ broader refactor.
`except AttributeError: pass`. Two `EvoLearner` instances used concurrently,
or `fit()` calls interleaved across threads, will clobber each other's DEAP
type definitions. Not thread-safe, and the failure mode is silent.
- **`ontolearn/concept_abstract_syntax_tree.py`** (e.g. lines 181, 200, 227,
233, 239, 248, 267…) — `_fix_mid_tokens_errors`/`_postprocess_tail_fix`
repair malformed token sequences via `random.choice(...)`, making parser
output non-deterministic across runs on identical input. Replace with a
deterministic tie-break (e.g. first sorted candidate) unless the randomness
is intentional.

## 2. Code duplication

Expand Down Expand Up @@ -182,7 +176,7 @@ broader refactor.

## Suggested priority order

1. Fix the remaining three correctness bugs in §1 (cheap, high-value, some are
1. Fix the remaining two correctness bugs in §1 (cheap, high-value, some are
one-liners).
2. Fix the two mutable-default-argument bugs in §4 (cheap, real risk).
3. Delete or restore the two fully-commented-out test files in §6.
Expand Down
Loading
Loading