Repository navigation
Fix dead disjointness check in LengthBasedRefinement.refine_atomic_co… - #604
Merged
Merged
Conversation
…ncept The if/else branches both yielded the same OWLObjectIntersectionOf, making the are_owl_concept_disjoint check a no-op. Now refinements into a named class disjoint with the current concept are skipped entirely, since intersecting with a disjoint class is unsatisfiable and not a useful refinement. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks done
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ncept
The if/else branches both yielded the same OWLObjectIntersectionOf, making the are_owl_concept_disjoint check a no-op. Now refinements into a named class disjoint with the current concept are skipped entirely, since intersecting with a disjoint class is unsatisfiable and not a useful refinement.