Repository navigation
Keep layered portrait preview bounds finite - #2826
Open
upalvstavai wants to merge 1 commit into
Open
upalvstavai wants to merge 1 commit into
upalvstavai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2822.
Layered portrait coverage was calculated from
global_positionvalues. During an editor preview rebuild those global transforms can temporarily be invalid, especially after switching through an empty portrait, so subtracting them propagatedinf/NaNinto the preview rectangle.This computes each sprite's transform relative to the portrait root from local transforms instead. It does not depend on the root's global transform being ready, and it also measures all four transformed corners so nested, scaled, rotated, and mirrored layers remain covered correctly.
Added focused GdUnit coverage for:
(inf, inf)preview position and a nested sprite;Validation:
Result: 2 test cases, 0 errors, 0 failures, 0 orphans.
The macOS sandbox emitted the repository-documented system certificate warning and could not create
user://logs; neither affected the test result. Native Windows editor verification is still appropriate for the original Windows-only interaction sequence.