Repository navigation
Use copied resources in customized scenes - #2823
Open
upalvstavai wants to merge 1 commit into
Open
upalvstavai wants to merge 1 commit into
upalvstavai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2820.
When
make_file_custom()copied a scene and its neighboring resources, it changed each resource path but left the original resource UID in the scene. Godot resolves the UID first, so a newly created layered portrait still loaded the template script from the Dialogic addon even though the saved scene text pointed at the copied script.This change replaces the complete resource reference while customizing a scene, removing the stale UID and writing the copied path. A regression test checks both the saved scene text and the script actually loaded by an instantiated customized portrait.
Validation:
user://.../custom_layered_portrait.gd, but the instantiated scene loadedres://addons/dialogic/Modules/LayeredPortrait/custom_layered_portrait.gd.user://script.Tests/Unitsuite passes: 17 cases, zero errors, failures, flaky tests, skipped tests, or orphan nodes.The fix was prepared with the assistance of an AI coding tool and reviewed and behavior-tested before submission.