Repository navigation
Fix inherited style overrides and VN name label alignment - #2810
Open
Minato-chen wants to merge 1 commit into
Open
Minato-chen wants to merge 1 commit into
Minato-chen wants to merge 1 commit into
Conversation
Member
|
Hi @Minato-chen thank you for this PR. It works correctly. However as I'm still working on a pretty substantial rework of styles (#2738) I think I won't merge this for now, instead I'll try to make sure that my PR also works correctly in this scenario. I'll leave it open until that PR makes it into main, just in case these changes still make sense like this afterwards. |
Author
|
@Jowan-Spooner Thanks for testing it and for the update. That makes sense. I'll leave this PR open while #2738 is in progress. I'm also happy to test the same inheritance and runtime style-switching scenarios again once the rework is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inherited styles did not always save or apply their settings correctly.
If a child style was missing local layer data, changing a setting could fail without showing an error. The Style Editor also treated inherited values as if they were saved directly in the child style.
When switching between inherited styles during a dialogue, Dialogic could use the wrong layer ID. This caused some settings, such as name label alignment, to return to their default values.
The VN textbox name label also kept anchors and offsets from the previous style. After several style changes, the label could appear in the wrong position.
Changes
Testing
I tested:
Fixes #2698