New bug in vertical alignment in version 1.8.2 (VerticalAlignment.MIDDLE sometimes not respected)

[Susan123456789]

I recently upgraded from boxable 1.7.0 to 1.8.2 and the new vertical alignment behaviour seems to have a bug in it. The following cells all use VerticalAlignment.MIDDLE and were generated with the exact same code before and after the upgrade to 1.8.2:

The behaviour is weird though. It looks like in other rows in my document, the VerticalAlignment.MIDDLE is respected if the cell comes before whatever cell caused the row height to grow (for example some wrapped text, or larger text), but not for cells that come after that cell in the row. The following cells all use VerticalAlignment.MIDDLE:

[Susan123456789]

Minimal reproducible example, all cells use VerticalAlignment.MIDDLE:

	public static void main(String[] args) throws IOException
	{
		try (PDDocument doc = new PDDocument())
		{
			PDPage page = new PDPage(PDRectangle.LETTER);
			doc.addPage(page);

			float pageWidth = page.getMediaBox().getWidth();
			float pageHeight = page.getMediaBox().getHeight();
			float pageMargin = 15f;
			float tableWidth = pageWidth - (2 * pageMargin);
			float yStart = pageHeight - pageMargin;

			BaseTable table = new BaseTable(yStart, yStart, pageMargin, tableWidth, pageMargin, doc, page, true, true);

			Row<PDPage> row;
			Cell<PDPage> cell;

			row = table.createRow(0f);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);
			cell.setFontSize(30f);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);

			row = table.createRow(0f);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);

			cell = row.createCell(25f, "MIDDLE but so long that it wraps several lines causing the row height to grow");
			cell.setValign(VerticalAlignment.MIDDLE);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);

			cell = row.createCell(25f, "MIDDLE");
			cell.setValign(VerticalAlignment.MIDDLE);

			table.draw();

			File file = new File("test.pdf");
			doc.save(file);
			System.out.println("Saved to " + file.getAbsolutePath());
		}
	}

Result:

I'm not even sure that the first or second columns look correctly aligned, and the last two columns are definitely at the top of the cell.

[Susan123456789]

Issue seems to have been introduced in 1.8.1, which looks the same as 1.8.2. 1.8.0 looks correct:

[Susan123456789]

I think I found the source of the bug:

In Table.drawCellContent when the cell is finished drawing it sets the cell's line start to Integer.MAX_VALUE:

                if (cellFinished) {
                     cell.setLineStart(Integer.MAX_VALUE);
                }

Then when drawing later cells in the row, Row.getHeight calls Cell.getCellHeight() on each cell in the row, which calls calls Cell.getTextHeight(), which calls getParagraph().getHeight(lineStart). But lineStart is Integer.MAX_VALUE since this cell has already been drawn, causing Paragraph.getHeight to return 0, causing the Row.getHeight to be miscalculated (returns the height of the largest cell that has not yet been drawn).

Paragraph.java:

    public float getHeight(int lineStart) {
        if (getLines().size() <= lineStart) {
            return 0;
        } else {
			float height = 0f;
			for (int i = lineStart; i < getLines().size(); i++) {
				float lineHeight = getLineHeight(i);
				height += (i == lineStart) ? lineHeight : lineHeight * getLineSpacing();
			}
			return height;
        }
    }

A zero paragraph height causes each of the already-drawn cells to have a much smaller calculated height, affecting the vertical alignment of the cells drawn after it.

Any chance this could be fixed and a new release created? I need to have both this fix and the image scaling fix (#268) for my document.

Thank you! Great library by the way! :)

[TryhardOne]

Any chance for a fix?

Thanks in advance