Repository navigation
fix(strings): transliterate ß, æ, ø and Ł in slugify - #459
Merged
Merged
Conversation
slugify relied on NFKD + ASCII encoding, which deletes letters that have no decomposition, so "Ærøskøbing" became "rskbing" and "Straße" "strae". Run the text through deburr first, which maps these letters.
|
coverage: 100.0%. remained the same — jayhemnani9910:fix/slugify-deburr into dgilland:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base: develop
slugifydrops letters that have no Unicode decomposition:It uses NFKD and then encodes to ASCII with
ignore. NFKD only splits letters like é into a base letter and a mark, so ß, æ, ø, Ł and œ are deleted.deburralready maps these (including the Latin Extended-A letters from #442), soslugifynow runs the text throughdeburrfirst:aeroskobing,strasse-5,lodz,ol-og-brod. The existing cases (Un éléphant à l'orée du bois, the apostrophes) give the same slugs.Added a
test_slugifycase that fails without the change.pytest tests: no new failures (the 334pytest_mypy_testingcases fail the same way on develop here). Changelog and AUTHORS updated.