Repository navigation
Conversation
dgilland
requested changes
Nov 15, 2026
dgilland
left a comment
Owner
There was a problem hiding this comment.
Lint check is failing on mypy:
Running mypy
tests/test_objects.py:342:9: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
ERROR: src/pydash/chaining/all_funcs.pyi is out of date. Please run `inv generate-chaining-types` and commit the changes.
PASSED
Running chaining-types-update-required
ERROR: linters failed: chaining-types-update-required
FAILED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
group_by() iterates mapping keys directly, unlike the other collection helpers. For example, group_by({'first': 1, 'second': 3}, parity) passes the strings 'first' and 'second' to a numeric callback, while the default iteratee produces groups of keys instead of values.
Group Mapping.values() with the existing loop. Add mapping-specific overloads and assert_type regressions, cover dict/UserDict/read-only MappingProxyType with identity, callable and shorthand iteratees, and add a dictionary example. Update the changelog and contributor list.
Validation on Windows / CPython 3.12.10:
The full supported interpreter/OS matrix was not run locally. AI assistance: OpenAI Codex was used for investigation, implementation and running the validation commands.