Repository navigation
Support range sequences in index_of - #455
Merged
dgilland merged 2 commits intoNov 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
index_ofpasses a start argument to the sequence'sindexmethod. Python'srange.indextakes only a value, so every range lookup previously raisedTypeError. Slice the range at the requested start, use its native lookup, and translate a match back to its original index. Range slicing preserves constant space and the native arithmetic lookup for integer values.Fixes #454.
Validation
TypeError. Eleven new cases pass with the patch, covering positive and negative starts, descending and empty ranges, missing values, numeric equality, and a range larger thansys.maxsize.OpenAI Codex (GPT-6 based) assisted with investigation, implementation, testing and drafting.