Repository navigation
Propagate errors raised while consuming to_list inputs - #409
Merged
dgilland merged 2 commits intoNov 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #408.
Catch
TypeErroronly while obtaining an iterator into_list's generic fallback, then consume that iterator outside the handler. A generator or legacy sequence that raisesTypeErrorwhile producing values now propagates the original exception, instead of silently returning a list containing the partially consumed source.The scalar/non-iterable fallback remains supported, including objects whose
__iter__raisesTypeError. Existing list, dict, string and bytes branches are unchanged. Add a documentation clarification and unreleased changelog entry; signatures, dependencies and generated chain files do not change. Existing AUTHORS credit is retained.Validation
Windows / CPython 3.13.13:
785e82b, all fourteen pass after the fix. Direct/chained generator and legacy-sequence cases assert that the original exception instance propagates. Eight non-iterable cases retain identity when wrapped; two length-hint controls agree with Python's builtinlistbehavior, which ignoresTypeErrorfrom the optional hint.git diff --check: passed.Other Python versions/platforms were not run locally. Hosted Main run 41365825470 is in progress; its result is not yet claimed.
Origin and assistance
Found by source inspection, not a production incident. Checked the open PR inventory and all-state
to_list/iteration-error searches, including #107's original scalar-wrapping rationale, before reporting the distinct failure-handling problem.OpenAI Codex (GPT-6 family; exact deployment identifier unavailable) assisted with investigation, implementation and verification. The user requested independently useful, tested contributions and avoidance of duplicate work; no independent human review is claimed.