Repository navigation
Reuse sized iterator values when calculating variance - #399
Merged
dgilland merged 1 commit intoNov 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variance(numpy.array([1., 2., 3.]).flat)returns NaN instead of 2/3. The input has a length, so it is not saved before the mean consumes it; the squared-deviation pass then sees no items.std_deviationinherits this problem.Materialize iterator inputs even when they implement
__len__. Reusable sized collections retain their existing path. Regression tests use a dependency-free sized iterator and cover variance, standard deviation, single-item and empty inputs. Controls verify that dict, UserDict and mapping-proxy inputs still process values.Validation on Windows:
Checked current contribution instructions and existing issues/PRs. Earlier merged #261 handles unsized iterators; this fixes the remaining sized-iterator path. No overlapping open change was found. The account already appears in AUTHORS.rst.
AI assistance: OpenAI Codex investigated, implemented and tested this change at the account owner's request,
aro 2ta, expanded toeta soho aro 25ta koro???. No independent human review is claimed.