Repository navigation
Sort integer keys with default order_by directions - #398
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
order_by([[2], [1]], [0], [])raisesAttributeError: 'int' object has no attribute 'startswith', although the same integer key works with[True]. Default directions, exhausted order iterators and the legacy boolean reverse option reach the same string-only branch.Apply the descending-prefix check only to string keys, leaving integer keys/indexes intact. Update both public and chain overloads for omitted orders, document integer keys, and cover mixed numeric/string keys, mapping collections, chaining, stable equal-key ordering, reverse options and unchanged input data.
Validation on Windows:
test_debouncetiming failure.Checked current contribution instructions and existing issues/PRs; no overlapping open fix was found. The account already appears in AUTHORS.rst.
AI assistance: OpenAI Codex investigated, implemented and tested this change at the account owner's request,
aro 2ta, expanded toeta soho aro 25ta koro???. No independent human review is claimed.