Skip to content

fix(strings): honor ignore_case for compiled patterns - #396

Merged
dgilland merged 3 commits into
dgilland:developfrom
awais-ur-rehman:feat/compiled-ignore-case
Nov 1, 2026
Merged

dgilland merged 3 commits into
dgilland:developfrom
awais-ur-rehman:feat/compiled-ignore-case

Conversation

@awais-ur-rehman

Copy link
Copy Markdown
Contributor

Summary

replace, replace_start, and replace_end silently ignore ignore_case=True when their pattern is already compiled. Merge the requested flag with the pattern's existing flags, so case-insensitive replacement behaves the same for strings and compiled expressions.

Testing

The regression covers all three helpers, preserves DOTALL, checks the default remains case-sensitive, and confirms the caller's compiled pattern stays unchanged. Additional DEBUG-pattern controls verify that unchanged compiled flags do not trigger diagnostic stdout. On Python 3.13, all 3,084 tests pass with 100% coverage; full Ruff, formatting, mypy, generated chaining checks, the Sphinx documentation build, and sdist/wheel builds pass. No public signature changes; existing calls without ignore_case=True retain their flags.

Codex assisted with the implementation and tests.

Breaking Changes

None.

Manual verification: Use a compiled DOTALL pattern matching a newline with ignore_case=True; all three replacement helpers should match uppercase input, preserve existing flags and leave the supplied pattern unchanged.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — awais-ur-rehman:feat/compiled-ignore-case into dgilland:develop

@dgilland
dgilland merged commit 785e82b into dgilland:develop Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants