Repository navigation
fix(strings): honor ignore_case for compiled patterns - #396
Merged
dgilland merged 3 commits intoNov 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace,replace_start, andreplace_endsilently ignoreignore_case=Truewhen their pattern is already compiled. Merge the requested flag with the pattern's existing flags, so case-insensitive replacement behaves the same for strings and compiled expressions.Testing
The regression covers all three helpers, preserves DOTALL, checks the default remains case-sensitive, and confirms the caller's compiled pattern stays unchanged. Additional DEBUG-pattern controls verify that unchanged compiled flags do not trigger diagnostic stdout. On Python 3.13, all 3,084 tests pass with 100% coverage; full Ruff, formatting, mypy, generated chaining checks, the Sphinx documentation build, and sdist/wheel builds pass. No public signature changes; existing calls without
ignore_case=Trueretain their flags.Codex assisted with the implementation and tests.
Breaking Changes
None.
Manual verification: Use a compiled DOTALL pattern matching a newline with ignore_case=True; all three replacement helpers should match uppercase input, preserve existing flags and leave the supplied pattern unchanged.