Repository navigation
Preserve arithmetic result types across mean APIs - #392
Merged
dgilland merged 2 commits intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #391.
mean/mean_by/moving_mean currently annotate float results even when arithmetic returns Decimal, Fraction or complex values. Track division-by-count results with a structural SupportsMean protocol and include float for the empty-input NaN case. Int/float inputs retain their existing float inference. Propagate the same result type through moving_mean and regenerate chain declarations; runtime arithmetic is unchanged.
The new focused tests fail type checking before the fix while runtime execution already passes. They cover direct/mapping/iteratee/chained calls, Decimal/Fraction/complex, integer/float controls, empty NaN and Decimal moving windows. Three existing integer-control reveal_type snapshots were changed to assert_type only for these affected mean APIs: current mypy renders float/list[float] instead of builtins.float/builtins.list[builtins.float]. Expected types are unchanged; other snapshots were not rewritten.
Validation on Windows / CPython 3.13.13:
Unreleased changelog updated; existing AUTHORS entry retained. This complements merged #375's median correction and is separate from #261's runtime iterator fix and pending #390's reducer calls. Found through code inspection, not production use. OpenAI Codex (GPT-6 family; exact deployment identifier unavailable) assisted with investigation, implementation, tests and submission under the user's daily contribution request.