Repository navigation
Match empty iterable sources without testing their truth value - #382
Merged
dgilland merged 2 commits intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_match([], iter([])) returns False, while the equivalent empty-list source returns True. is_match_with truth-tests the source before iterating it; unsized empty iterators are truthy, and iterable containers with no scalar truth value raise instead. Initialize the empty-conjunction result to True and let actual comparisons determine nonempty matches.
Five new regressions fail before the fix, with nonempty mismatch controls. Full unit tests and doctests: 2,987 passed on Python 3.12 and 3.10; 100% coverage on 3.12. Ruff formatting/lint, mypy over package plus changed tests, and diff checks pass. The separate mypy-testing collection, other Python versions, packaging and documentation builds were not run.
Found during source inspection. Prepared with OpenAI Codex (GPT-6) assistance for
new 20ta koro(make 20 new contributions). Investigation, implementation and tests were AI-assisted; no personal production use or human code review is claimed.