Skip to content

fix(arrays): avoid recursion limits in XOR helpers - #381

Merged
dgilland merged 3 commits into
dgilland:developfrom
edsonsims:fix/xor-many-arrays
Oct 27, 2026
Merged

dgilland merged 3 commits into
dgilland:developfrom
edsonsims:fix/xor-many-arrays

Conversation

@edsonsims

Copy link
Copy Markdown
Contributor

The XOR helpers use one Python stack frame for each additional array, so valid calls with many arrays fail with RecursionError. I replaced the tail calls with a loop while preserving the existing pairwise comparisons, callback order, iterator consumption and single-array paths.

Seven new regression cases fail before the fix and pass afterward. The full suite passes 2,887 tests with 100% statement coverage on Python 3.10, 3.12 and 3.13; local inv ci also passes package and documentation builds, Ruff, MyPy and the generated chaining-type check on 3.13.

@coveralls

coveralls commented Oct 27, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — edsonsims:fix/xor-many-arrays into dgilland:develop

edsonsims and others added 2 commits October 26, 2026 21:03
Keep the upstream terminal uniq_with behavior in both iterative paths,
including the final comparator pass after reducing multiple arrays.
Preserve the incoming source, type, test, and changelog changes.
@dgilland
dgilland merged commit d3cf971 into dgilland:develop Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants