Skip to content

Honor false-valued retry exception callbacks - #354

Merged
dgilland merged 1 commit into
dgilland:developfrom
Gambit-Checkmate:fix/retry-falsey-callback
Oct 27, 2026
Merged

dgilland merged 1 commit into
dgilland:developfrom
Gambit-Checkmate:fix/retry-falsey-callback

Conversation

@Gambit-Checkmate

Copy link
Copy Markdown
Contributor

Summary

Closes #352.

Distinguish an absent optional exception callback from a valid callable whose boolean value is False. Use None checks consistently for callback validation, arity inspection and invocation.

The regression fails before the fix because no callback is invoked. It checks all three failure notifications, retry/sleep counts and propagation of the final exception with sleep mocked.

Full suite: 2,881 passed, 100% coverage.

Validation

  • Full unit/doctest suite with 100% coverage gate.
  • Ruff lint/format, mypy, Sphinx -W, sdist/wheel build, generated chaining types comparison and git diff --check passed.
  • Windows / Python 3.13.13 locally; other supported Python versions await upstream CI.
  • Existing AUTHORS credit retained, unreleased changelog entry added.

AI disclosure: prepared with OpenAI Codex assistance, found through code inspection and reproduced locally. No production incident is claimed.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — Gambit-Checkmate:fix/retry-falsey-callback into dgilland:develop

@dgilland
dgilland merged commit 36ffd77 into dgilland:develop Oct 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

retry silently ignores false-valued on_exception callables

3 participants