Repository navigation
Honor false-valued retry exception callbacks - #354
Merged
dgilland merged 1 commit intoOct 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #352.
Distinguish an absent optional exception callback from a valid callable whose boolean value is False. Use None checks consistently for callback validation, arity inspection and invocation.
The regression fails before the fix because no callback is invoked. It checks all three failure notifications, retry/sleep counts and propagation of the final exception with sleep mocked.
Full suite: 2,881 passed, 100% coverage.
Validation
-W, sdist/wheel build, generated chaining types comparison andgit diff --checkpassed.AI disclosure: prepared with OpenAI Codex assistance, found through code inspection and reproduced locally. No production incident is claimed.