Skip to content

chore(backend): return a ready future from the composite exchange test mock #13994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntonioVentilii merged 4 commits into from
Sep 10, 2026
Merged

chore(backend): return a ready future from the composite exchange test mock #13994

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8797a9
chore(backend): return a ready future from the composite exchange tes…
AntonioVentilii Sep 9, 2026
c7c6c9b
Merge branch 'main' into av/backend-unused-async-trait-impl
AntonioVentilii Sep 9, 2026
8916780
Merge branch 'main' into av/backend-unused-async-trait-impl
AntonioVentilii Sep 10, 2026
1cffb63
Merge branch 'main' into av/backend-unused-async-trait-impl
AntonioVentilii Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/backend/src/exchange/composite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ pub(crate) async fn fetch_all_prices<P: ExchangePriceProvider>(

#[cfg(test)]
mod tests {
use std::{cell::RefCell, rc::Rc};
use std::{
cell::RefCell,
future::{ready, Future},
rc::Rc,
};

use candid::Principal;
use futures::executor::block_on;
Expand All @@ -106,11 +110,11 @@ mod tests {
}

impl ExchangePriceProvider for MockPrimaryProvider {
async fn fetch_prices(
fn fetch_prices(
&self,
_token_ids: &[StoredTokenId],
) -> Result<Vec<(StoredTokenId, ExchangeData)>, String> {
self.result.clone()
) -> impl Future<Output = Result<Vec<(StoredTokenId, ExchangeData)>, String>> {
ready(self.result.clone())
}
}

Expand Down
Loading