feat: added new SignerInitOptions and removed unnecessary owner tests - #510
Draft
roman-nazaruk wants to merge 4 commits into
Draft
feat: added new SignerInitOptions and removed unnecessary owner tests#510roman-nazaruk wants to merge 4 commits into
roman-nazaruk wants to merge 4 commits into
Conversation
peterpeterparker
left a comment
peterpeterparker
left a comment
Contributor
There was a problem hiding this comment.
Why create SignerOptionsSchema? What is the purpose of this schema and its types?
roman-nazaruk
marked this pull request as draft
March 17, 2025 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are updating the oisy-signer so that it now waits for a valid owner to be set before processing non‑read‑only messages, ensuring that it returns a clear NOT_INITIALIZED error when not logged in.
Changes
Added a new SignerInitSchema and SignerInitOptions without the owner property, allowing the Signer to establish a connection without specifying an owner.
Tests
Removed unnecessary tests for the owner field in SignerInitOptions.