test(fe): run the tab and sibling-subdomain session scenarios in a browser - #4289
Open
sea-snake wants to merge 136 commits into
Open
test(fe): run the tab and sibling-subdomain session scenarios in a browser#4289sea-snake wants to merge 136 commits into
sea-snake wants to merge 136 commits into
Conversation
sea-snake
marked this pull request as ready for review
August 26, 2026 12:56
sea-snake
added
feature:revocable-app-sessions
|
✅ No security or compliance issues detected. Reviewed everything up to 2002845. Security Overview
Detected Code Changes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Playwright E2E spec to exercise the “More than one tab, and sibling subdomains” session-sharing scenarios from docs/ongoing/session-test-scenarios.md, validating cross-tab and cross-subdomain session continuity and sign-out propagation for the session-based (ICRC-25) flow.
Changes:
- Introduces a new
tabs-and-siblings.spec.tssuite covering multi-tab same-origin session reuse and sign-out visibility. - Adds sibling-subdomain scenarios that explicitly configure derivation origin + shared cookie domain and validate silent re-auth from a shared session hint.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sea-snake
force-pushed
the
test/session-e2e-tabs-and-siblings
branch
2 times, most recently
from
August 26, 2026 13:34
4006c1a to
33e2c24
Compare
sea-snake
force-pushed
the
test/session-e2e-tabs-and-siblings
branch
from
August 26, 2026 13:36
33e2c24 to
436e7a8
Compare
sea-snake
force-pushed
the
test/session-e2e-tabs-and-siblings
branch
from
August 26, 2026 13:53
436e7a8 to
b027c00
Compare
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVi99RYo2jyi2kCurgovNJ
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVi99RYo2jyi2kCurgovNJ
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
sea-snake
removed this pull request from stack #4294
September 9, 2026 20:42
sea-snake
added this pull request to stack #4327
September 9, 2026 20:44
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
…2e-tabs-and-siblings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "More than one tab, and sibling subdomains" scenarios of
docs/ongoing/session-test-scenarios.md— SHARE-1, SHARE-2, SHARE-3, SHARE-5 and SHARE-6.One sign-in serves every tab of an origin, and every subdomain of a domain that announces it. A tab or a sibling that was never signed in to arrives working, and loses it when the one that did signs out.
The two sibling scenarios configure the app per subdomain — a derivation origin, and the domain to announce the session across — which
authorizeConfighas no field for, so they drive the app themselves. They also declare the siblings as alternative origins first, which the one canister serving all three hosts makes a single write.