-
Notifications
You must be signed in to change notification settings - Fork 0
Ship a Claude Desktop bundle with every local-MCP release, and explain the install scripts #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
565e3eb
Explain the install scripts in the release notes, and document a veri…
claude a4d811b
Address review: stop relying on releases/latest, and fix the install …
claude 90d789f
Address review: paginate the release lookup, and fail the install closed
claude 026028a
Point the release notes at `imcp2-local setup`
claude 174a8b6
Ship a Claude Desktop bundle (imcp2-local.mcpb) with every release
claude 3c95c75
Address review: verify the bundle's inputs' provenance, and fix SIGPI…
claude 13eb40d
Address review: pin every attestation check to its release tag, and h…
claude e06c734
Say what the installer does when it skips its checksum
claude 29ff585
Address review: keep credentials away from third-party code, and lock…
claude 1e7ac1d
Run the new release jobs on current runner images
claude e8aa97e
Check each universal-binary slice against its attested input
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <!-- install-script-summary --> | ||
| > **What the install scripts below do:** each downloads the `imcp2-local` binary for your platform from this release, installs it plus an auto-updater into `~/.cargo/bin`, and adds that directory to your PATH — the shell script by appending a line to every shell profile it can find, the PowerShell script by editing your `Path` registry key. The shell script also compares a checksum baked into itself, but skips that check silently on stock macOS, which has no `sha256sum`; the PowerShell script does not check one at all. Where that shell checksum does run it ships inside the very script being piped to a shell, so on either platform the attestation commands at the end of these notes are what establish provenance — `IMCP2_LOCAL_NO_MODIFY_PATH=1` and `IMCP2_LOCAL_DISABLE_UPDATE=1` opt out of the PATH edits and the updater. | ||
| > | ||
| > **Then connect it to your AI tool:** `imcp2-local setup` registers the server with the clients on this machine — Claude Desktop, Claude Code, Codex, Cursor, Antigravity — and prints Perplexity's UI steps; `imcp2-local setup --print` shows each client's steps without writing anything, and `imcp2-local setup --remove` undoes them. Restart the client afterwards. The [README](https://github.com/dfinity/imcp2/blob/main/crates/imcp2-local/README.md#register-it-with-your-ai-tools) lists the per-client registration each one receives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Prepends a plain-language summary of what the install scripts do to the | ||
| # release notes `dist` writes for an `imcp2-local-v*` release. | ||
| # | ||
| # Why a job rather than a setting: dist builds the release body itself (the | ||
| # install one-liners, the download table, the attestation section) and has no | ||
| # config for extra prose — a custom job is the only documented seam. This one | ||
| # hangs off `post-announce-jobs` in dist-workspace.toml, so `dist generate` | ||
| # keeps wiring it in and the release workflow stays reproducible from config. | ||
| # | ||
| # The prose lives in .github/release-notes/imcp2-local-install-note.md so it | ||
| # is reviewed as rendered markdown rather than as a string inside YAML. Keep | ||
| # it in step with the installers and with the crate README's Install section. | ||
| # | ||
| # Runs after the release is published and edits the notes in place; the | ||
| # marker in that file makes a re-run a no-op. | ||
| name: imcp2-local install note | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| plan: | ||
| required: true | ||
| type: string | ||
|
|
||
| jobs: | ||
| install-note: | ||
| runs-on: ubuntu-22.04 | ||
| permissions: | ||
| contents: write | ||
| env: | ||
| PLAN: ${{ inputs.plan }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NOTE_FILE: .github/release-notes/imcp2-local-install-note.md | ||
| steps: | ||
| # Pinned to a commit SHA, as every other action in this pipeline is. | ||
| - name: Checkout | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Prepend the install-script summary to the release notes | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
|
|
||
| tag="$(printf '%s' "$PLAN" | jq -er '.announcement_tag')" | ||
| marker="$(head -n 1 "$NOTE_FILE")" | ||
|
|
||
| body="$(gh release view "$tag" --repo "$GITHUB_REPOSITORY" --json body -q .body)" | ||
| if printf '%s' "$body" | grep -qF "$marker"; then | ||
|
aterga marked this conversation as resolved.
Outdated
|
||
| echo "summary already present on $tag — nothing to do" | ||
| exit 0 | ||
| fi | ||
|
|
||
| { | ||
| cat "$NOTE_FILE" | ||
| printf '\n%s\n' "$body" | ||
| } > "$RUNNER_TEMP/notes.md" | ||
|
|
||
| gh release edit "$tag" --repo "$GITHUB_REPOSITORY" --notes-file "$RUNNER_TEMP/notes.md" | ||
| echo "install-script summary added to $tag" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.